Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test protocol apply #971

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Test protocol apply #971

wants to merge 7 commits into from

Conversation

Pilou97
Copy link
Contributor

@Pilou97 Pilou97 commented Nov 7, 2022

Problems:

  • We needs to test how operations are applied in the protocol
  • A bug was discovered: user can withdraw 0 ticket, it should bot be possible because in Tezos the amount of tickets are strictly positive

Solutions:

Add tests for:

  • noop operation
  • transfer operation
  • ticket deposit
  • ticket withdraw

Add some tests on different used types:

  • operation hash
  • address

Fix the bug to prevent a user from generated a withdraw of 0 ticket

@Pilou97 Pilou97 changed the title Pilou/test protocol Test protocol apply Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoRFS EduardoRFS Awaiting requested review from EduardoRFS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pilou97